Fix create namespace problem #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
reviewed
Nov 8, 2021
|
Looks good, is there an associated issue, or simply fixing a bug you've found? EDIT: No-Issue |
himdel
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating namespace, there is search dropdown list. Before this PR, it worked this way:
In dropdown list, there is list of available groups. When one group is selected, it appears in bottom of the drop down in selected group permission area and it dissapears from the search drop down. This is fine. But when the group is removed, it is not available in search drop down again. This PR fixed this by adding the removed group back to drop down.
No Issue.