[PR #1216/8b34c28c backport][stable-4.4] Fix i18n issue #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* Fixing the test to prove translatedable strings are correct in prod * Fixes https://issues.redhat.com/browse/AAH-982 Extract and compile new translatable strings to prevent wrong display in prod that looks like "string{0}string" (cherry picked from commit 8b34c28)
Merged
himdel
deleted the
patchback/backports/stable-4.4/8b34c28ca9ffdf3b75fcc53029e902e41a26d26b/pr-1216
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1216 as merged into master (8b34c28).
Fixes AAH-982
Adding missing compiled files to fix
"string {0} string"issue in prod.Fixed a test that was failing because of it to prove it's fixed.
Before the fix:
After:
馃煝
@himdel Someone's gonna have the most new lines Milan Zazrivec style :D