Add check that EE name is correct when typed in #1220

ZitaNemeckova · 2021-11-09T12:28:25Z

Fixes https://issues.redhat.com/browse/AAH-968

Steps to reproduce:

go to http://localhost:8002/ui/containers
click "Add execution environment" button
set the name to something invalid like "i/am/an/invalid/container/name"
click save

(Screenshots are in French because I'm looking for possible problems with translation)
Before:

After:

This is not fixed in #1115 and is not related to that PR.

@himdel please have a look, thanks :)

src/components/execution-environment/repository-form.tsx

src/containers/execution-environment-list/execution_environment_list.tsx

himdel · 2021-11-15T19:38:44Z

(test failures seem relevant...)

src/components/execution-environment/repository-form.tsx

awcrosby · 2021-12-01T22:18:14Z

(adding this to a few recently updated PRs…) We need CI in this repo that enforces this, but for now please:

Add a line to at least one of your commits that says Issue: AAH-#### (in the future it is best to be the first commit as it gets included in the initial PR description by default)
Ensure when merging that the Issue: AAH-#### is part of commit message via the “Squash ‘n’ Merge” description

src/components/execution-environment/repository-form.tsx

src/containers/execution-environment-list/execution_environment_list.tsx

himdel · 2022-01-04T06:24:42Z

Needs a rebase, but LGTM :)
(I think the conflict was just about removing !!)

ZitaNemeckova · 2022-01-04T10:40:41Z

@himdel rebased and ready for review :)

himdel · 2022-01-04T22:47:32Z

Tested in the UI, looks like everything works, just one more thing... :)

(correct:) Namespaces > Create ...there is no error when name is empty, until you enter something and remove it again.
(here:) EE > Add execution environment ...shows the validation error right away:

(and we may need a better message for when the field is empty .. namespaces uses Please, provide the namespace name )

Looks like namespaces is running the validation from onChange, not sure if you want to do the same thing or not, maybe all we need is to set state.pristine = true, change to false in onChange, and then we can have validated={pristine || this.validateName(name)} on the FormGroup, without affecting the save button :)

ZitaNemeckova · 2022-01-05T12:35:02Z

@himdel Fixed as suggested. Just had to move it to the validateName because PF component works with "default"/"error" instead of boolean. So it's ready for another round of review :)

ZitaNemeckova · 2022-01-05T12:45:27Z

src/components/execution-environment/repository-form.tsx

        </Form>
      </Modal>
    );
  }

+  private validateName(name) {
+    const regex = /^([0-9A-Za-z._-]+\/)?[0-9A-Za-z._-]+$/;
+    if (name === '' || regex.test(name)) {


@himdel This is the change you are looking for.

Works for me :), formIsValid still ensures non-empty name 👍

Issue: https://issues.redhat.com/browse/AAH-968 Disable Save button if name is not correct Do not check name if EE is remote Add alert when EE is saved to let an user to know Check that slash is not there or once Show error messages in the form Fix regex according to review Do not check to validate name if editing Remove testing changes Move new isDisabled logic to a function. Fix the condition to be simple Do not check length if local Make the formIsValid function more readable Issue: AAH-968 Fix typo numbers -> characters And linting issue. Move Alert out of FormGroup Add error handling to detail page as well Don't show name format error message when that input is empty Add changelog

Issue: https://issues.redhat.com/browse/AAH-968 Disable Save button if name is not correct Do not check name if EE is remote Add alert when EE is saved to let an user to know Check that slash is not there or once Show error messages in the form Fix regex according to review Do not check to validate name if editing Remove testing changes Move new isDisabled logic to a function. Fix the condition to be simple Do not check length if local Make the formIsValid function more readable Issue: AAH-968 Fix typo numbers -> characters And linting issue. Move Alert out of FormGroup Add error handling to detail page as well Don't show name format error message when that input is empty Add changelog (cherry picked from commit f7b1e2b)

himdel · 2022-01-11T21:22:00Z

backporting manually in #1497

Issue: https://issues.redhat.com/browse/AAH-968 Disable Save button if name is not correct Do not check name if EE is remote Add alert when EE is saved to let an user to know Check that slash is not there or once Show error messages in the form Fix regex according to review Do not check to validate name if editing Remove testing changes Move new isDisabled logic to a function. Fix the condition to be simple Do not check length if local Make the formIsValid function more readable Issue: AAH-968 Fix typo numbers -> characters And linting issue. Move Alert out of FormGroup Add error handling to detail page as well Don't show name format error message when that input is empty Add changelog (cherry picked from commit f7b1e2b)

Issue: https://issues.redhat.com/browse/AAH-968 Disable Save button if name is not correct Do not check name if EE is remote Add alert when EE is saved to let an user to know Check that slash is not there or once Show error messages in the form Fix regex according to review Do not check to validate name if editing Remove testing changes Move new isDisabled logic to a function. Fix the condition to be simple Do not check length if local Make the formIsValid function more readable Issue: AAH-968 Fix typo numbers -> characters And linting issue. Move Alert out of FormGroup Add error handling to detail page as well Don't show name format error message when that input is empty Add changelog (cherry picked from commit f7b1e2b) Co-authored-by: ZitaNemeckova <znemecko@redhat.com>

ZitaNemeckova force-pushed the ee_errors branch from 1a30b60 to 589bea9 Compare November 9, 2021 13:17

ZitaNemeckova requested a review from himdel November 9, 2021 13:27

ZitaNemeckova added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Nov 9, 2021

ZitaNemeckova force-pushed the ee_errors branch from 58ec52c to 95159a3 Compare November 9, 2021 13:30

himdel reviewed Nov 9, 2021

View reviewed changes