Api token page UX issues #1224
Merged
Api token page UX issues #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaiahWren
force-pushed
the
API-Token-page-UX-issues
branch
3 times, most recently
from
062fb5e
to
e404e54
Compare
himdel
reviewed
Nov 16, 2021
| @@ -95,7 +96,11 @@ class TokenPage extends React.Component<RouteComponentProps, IState> { | |||
| <ClipboardCopy>{tokenData.refresh_token}</ClipboardCopy> | |||
| </div> | |||
| ) : ( | |||
| <Button onClick={() => this.loadToken()}>{t`Load token`}</Button> | |||
| <div> | |||
There was a problem hiding this comment.
should this also have className='load-token'?
|
There's one more Apart from that (and the potentially missing load-token from insights), LGTM 👍 :) |
…, API token management.
ShaiahWren
force-pushed
the
API-Token-page-UX-issues
branch
from
e404e54
to
d18d29d
Compare
|
@himdel The classname="load-token" isn't needed on the button in insights mode, Susan says that button looks fine. It was just in standalone. I removed the scss import because it isn't being used. :) |
himdel
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello :)
This pr address UX issues on the Token API page discussed here: https://issues.redhat.com/browse/AAH-826
API token management.Before:
After:
