Remove filter drop down #1227
Remove filter drop down #1227
Conversation
|
NOTE - what do you Martin think about the margin solution? I think its not good, but I could not make vertical align with table cell display work :( Though the solution worked in my testing html file, but it is not working in ansible... My local test file works:
Text! (The HTML does not show until edit mode :) )
|
|
@MilanPospisil Before and After screenshots, please :) |
|
Before |
|
@sbuenafe-rh Do we have any designs for this please? (Assuming we go with the one in the screenshot...) (by "the text" I mean "Container repository name") |
| @@ -93,6 +94,14 @@ export class CompoundFilter extends React.Component<IProps, IState> { | |||
| isPlain={false} | |||
| items={filterOptions} | |||
| /> | |||
| ); | |||
| } else { | |||
| select = <div style={{ margin: '10px' }}>{filterConfig[0].title}</div>; | |||
There was a problem hiding this comment.
(I think you'll want something like margin: '8px 4px 0 0', to only set the top and right one (+- numbers, or possibly +-margin vs padding))
But if it helps, .pf-c-input-group is a flex element, it might help with the centering, if centering is enough.
|
@himdel it should only be the Filter by container repository name input field. Container repository name text in the front of this field should be removed. |
So the name should not be visible at all? |
That's right, the user can still see it in the placeholder or in active filters.
LGTM 👍 |
Remove filter drop down when it has only 1 item. It shows text of the selected item instead.