-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH Action to weekly update i18n #1249
Conversation
d8cc326
to
ceac01d
Compare
2a6c3bb
to
565ad83
Compare
This will be done only for master and stable-4.4 for now
aa84cc5
to
a0fcee0
Compare
(adding this to a few recently updated PRs…) We need CI in this repo that enforces this, but for now please:
|
12e1f38
to
e1864aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 :)
Backport to stable-4.4: 💚 backport PR created✅ Backport PR branch: Backported as #1370 🤖 @patchback |
* Add GH Action to weekly extract and compile strings and push them This will be done only for master and stable-4.4 for now * Do not run on merge * Remove unused env variable and commit only if there are changes Issue: AAH-1123 (cherry picked from commit d801113) Co-authored-by: ZitaNemeckova <znemecko@redhat.com>
git add locale/ | ||
if git commit -m "Automated updated of i18n strings on $(date +'%Y-%m-%d')"; then | ||
git push --set-upstream origin | ||
if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah :)
if | |
fi |
https://github.com/ansible/ansible-hub-ui/runs/4572955455?check_suite_focus=true#step:5:10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(fixed in #1460)
To prevent weird strings in production when they are not extracted and compiled.
Fixes https://issues.redhat.com/browse/AAH-1123