Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH Action to weekly update i18n #1249

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Conversation

ZitaNemeckova
Copy link
Member

@ZitaNemeckova ZitaNemeckova commented Nov 15, 2021

To prevent weird strings in production when they are not extracted and compiled.

Fixes https://issues.redhat.com/browse/AAH-1123

@ZitaNemeckova ZitaNemeckova changed the title GH - i18n [WIP] GH - i18n Nov 15, 2021
This will be done only for master and stable-4.4 for now
@ZitaNemeckova ZitaNemeckova changed the title [WIP] GH - i18n GH - i18n Nov 26, 2021
@ZitaNemeckova ZitaNemeckova changed the title GH - i18n Add GH Action to weekly update i18n Nov 26, 2021
@ZitaNemeckova ZitaNemeckova added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Nov 26, 2021
.github/workflows/i18n.yml Outdated Show resolved Hide resolved
.github/workflows/i18n.yml Outdated Show resolved Hide resolved
.github/workflows/i18n.yml Outdated Show resolved Hide resolved
@awcrosby
Copy link
Contributor

awcrosby commented Dec 1, 2021

(adding this to a few recently updated PRs…) We need CI in this repo that enforces this, but for now please:

  • Add a line to at least one of your commits that says Issue: AAH-#### (in the future it is best to be the first commit as it gets included in the initial PR description by default)
  • Ensure when merging that the Issue: AAH-#### is part of commit message via the “Squash ‘n’ Merge” description

Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: LGTM 👍 :)

@himdel himdel merged commit d801113 into ansible:master Dec 13, 2021
@patchback
Copy link

patchback bot commented Dec 13, 2021

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/d801113428d90540b8b743bc2ba960d98fe3f7a0/pr-1249

Backported as #1370

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 13, 2021
* Add GH Action to weekly extract and compile strings and push them

This will be done only for master and stable-4.4 for now

* Do not run on merge

* Remove unused env variable and commit only if there are changes

Issue: AAH-1123
(cherry picked from commit d801113)
himdel pushed a commit that referenced this pull request Dec 13, 2021
* Add GH Action to weekly extract and compile strings and push them

This will be done only for master and stable-4.4 for now

* Do not run on merge

* Remove unused env variable and commit only if there are changes

Issue: AAH-1123
(cherry picked from commit d801113)

Co-authored-by: ZitaNemeckova <znemecko@redhat.com>
@github-actions github-actions bot added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Dec 13, 2021
git add locale/
if git commit -m "Automated updated of i18n strings on $(date +'%Y-%m-%d')"; then
git push --set-upstream origin
if
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(fixed in #1460)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4.4 This PR should be backported to stable-4.4 (2.1) backported-4.4 This PR has been backported to stable-4.4 (2.1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants