Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EE detail page: README is in a Card component as is its Edit button #1294

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

MilanPospisil
Copy link
Contributor

https://issues.redhat.com/browse/AAH-1113

Problem Description: EE detail page: README is not in a Card component as isn't its Edit button

QA Criteria: README has white background and its Edit button is in that background.

Proposed Solution: Use Card component and move README and Edit button to it. This goes for README Empty state as well. Ask Susan if you have any questions.

@MilanPospisil
Copy link
Contributor Author

Before:
CardComponentBefore
After:
CardComponentAfter

@himdel
Copy link
Collaborator

himdel commented Nov 24, 2021

  • No README
  • yes README
  • edit README

LGTM 👍 :)

@MilanPospisil MilanPospisil merged commit 4985958 into ansible:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants