Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix header on ee detail page #1316

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Fix header on ee detail page #1316

merged 2 commits into from
Dec 6, 2021

Conversation

ShaiahWren
Copy link
Contributor

@ShaiahWren ShaiahWren commented Dec 1, 2021 •
edited

See issue: https://issues.redhat.com/browse/AAH-1116
Assignments:

  • in the header sha should be a chip like in the table
  • in the header add a clickboard button after the sha chip that copies whole sha
  • add spacing in between lines in the header

Before:
Screen Shot 2021-12-01 at 11 31 26 AM

After:
Screen Shot 2021-12-01 at 12 38 42 PM

@sbuenafe-rh
Copy link

@ShaiahWren can we display the entire SHA and keep it in the blue filled label?

@ShaiahWren
Copy link
Contributor Author

@sbuenafe-rh the ShaLabel component I'm using actually truncates the sha if it's beyond n characters, but I can try doing something custom!

@ShaiahWren
Copy link
Contributor Author

@sbuenafe-rh fixed:)

@awcrosby
Copy link
Contributor

awcrosby commented Dec 1, 2021

(adding this to a few recently updated PRs…) We need CI in this repo that enforces this, but for now please:

  • Add a line to at least one of your commits that says Issue: AAH-#### (in the future it is best to be the first commit as it gets included in the initial PR description by default)
  • Ensure when merging that the Issue: AAH-#### is part of commit message via the “Squash ‘n’ Merge” description

@ShaiahWren ShaiahWren force-pushed the fix-header-on-EE-detail-page branch 2 times, most recently from 18c63c2 to 011d821 Compare December 2, 2021 20:29
@ShaiahWren
add spacing below sha and place sha in label
bbd8349
@ShaiahWren
Issue: AAH-1116
eb99437 
add spacing, blue label chip around sha, and clipboard copy
ZitaNemeckova
ZitaNemeckova approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@ZitaNemeckova ZitaNemeckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ShaiahWren
Copy link
Contributor Author

Issue: AAH-1116

@ShaiahWren ShaiahWren merged commit bc108b8 into ansible:master Dec 6, 2021
@ShaiahWren ShaiahWren deleted the fix-header-on-EE-detail-page branch December 6, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZitaNemeckova ZitaNemeckova ZitaNemeckova approved these changes

@himdel himdel Awaiting requested review from himdel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ShaiahWren @sbuenafe-rh @awcrosby @ZitaNemeckova