Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add '?' to all delete modals. (Issue: AAH-1148) #1318

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Add '?' to all delete modals. (Issue: AAH-1148) #1318

merged 2 commits into from
Dec 8, 2021

Conversation

MilanPospisil
Copy link
Contributor

https://issues.redhat.com/browse/AAH-1148

Problem Description: some delete modal titles have a '?', while others don't.

Proposed Solution: Add '?' to the end of all delete modal titles.

EE list view > delete
Collection > delete
Namespace > delete
Remote registry > delete

Example: 'Permanently delete container' >> 'Permanently delete container?'

@himdel
Copy link
Collaborator

himdel commented Dec 6, 2021 •
edited

The change looks good, but not enough places :)...

  • Delete group?
  • Remove user from group?
  • Delete user?
  • Delete remote registry?
  • Delete container (should be "Delete Execution Environment?" now)
  • Delete image
  • Delete namespace?
  • Delete collection version
  • Delete collection

(+- "permanently" which is being handled separately in #1252)

@himdel himdel mentioned this pull request Dec 6, 2021
Merged
himdel
himdel approved these changes Dec 7, 2021
View reviewed changes
Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

@MilanPospisil MilanPospisil merged commit caf6aa0 into ansible:master Dec 8, 2021
@newswangerd newswangerd added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Dec 10, 2021
@patchback
Copy link

patchback bot commented Dec 10, 2021 •
edited

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/caf6aa0ec08fdd9675ad5361af3eb231ac9f4a65/pr-1318

Backported as #1349

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 10, 2021
@MilanPospisil @patchback
Add '?' to all delete modals. (Issue: AAH-1148) (#1318)
6075aa3 
* Add ? to all delete modals.

Issue: AAH-1148

* Delete collection and Delete version collection question mark

(cherry picked from commit caf6aa0)
@patchback patchback bot mentioned this pull request Dec 10, 2021
Merged
himdel pushed a commit that referenced this pull request Dec 13, 2021
@patchback @MilanPospisil
Add '?' to all delete modals. (Issue: AAH-1148) (#1318) (#1349)
9c7b11a 
* Add ? to all delete modals.

Issue: AAH-1148

* Delete collection and Delete version collection question mark

(cherry picked from commit caf6aa0)

Co-authored-by: MilanPospisil <arkanus@seznam.cz>
@github-actions github-actions bot added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

Assignees
No one assigned
Labels
backport-4.4 This PR should be backported to stable-4.4 (2.1) backported-4.4 This PR has been backported to stable-4.4 (2.1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MilanPospisil @himdel @newswangerd