Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rescope class names #1382

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Rescope class names #1382

merged 1 commit into from
Dec 18, 2021

Conversation

epwinchell
Copy link
Contributor

Jira: https://issues.redhat.com/browse/RHCLOUD-16591

  • Add "hub" prefix to classes
  • Use PF/Platform class naming convention

@epwinchell epwinchell marked this pull request as draft December 17, 2021 15:55
@epwinchell epwinchell mentioned this pull request Dec 17, 2021
Closed
@epwinchell epwinchell marked this pull request as ready for review December 17, 2021 15:57
@epwinchell
Copy link
Contributor Author

@himdel I made a new PR

himdel
himdel approved these changes Dec 18, 2021
View reviewed changes
Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Tested in the UI, not seeing any visual changes 👍

@himdel himdel merged commit e98f153 into ansible:master Dec 18, 2021
@epwinchell
Copy link
Contributor Author

@himdel Thanks. I might make another pass later.

@epwinchell epwinchell deleted the rescope3 branch December 18, 2021 18:46
@himdel himdel mentioned this pull request Feb 20, 2022
Closed
@himdel himdel mentioned this pull request Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@epwinchell @himdel