Disable enter on submit empty filter string, disable empty filter from params URL #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilanPospisil
force-pushed
the
RepairEmptySearch
branch
from
522c772
to
66803ec
Compare
Merged
himdel
approved these changes
Jan 4, 2022
himdel
pushed a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Jan 4, 2022
…m params URL (ansible#1402) * Issue: AAH-820. Disable enter on submit filter, disable empty filter from params URL * eslint correction
himdel
added
backport-4.4
Backport to stable-4.4: 💚 backport PR created✅ Backport PR branch: Backported as #1467 🤖 @patchback |
github-actions
bot
added
the
backported-4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects previous PR, which was incomplete:
#1195
AAH-820
It disables enter (submit) when user fills only empty filter text. It also does not add empty filter parameters from URL to container component state.