Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections list test delete #1459

Merged

Conversation

MilanPospisil
Copy link
Contributor

Added deletion in Collections list test using galaxykit.

@himdel
Copy link
Collaborator

himdel commented Jan 4, 2022

Code looks good, but galaxykit namespace delete my_namespace seems to be failing for some reason.

If the new version of galaxykit is not released yet you may need this change:

diff --git a/.github/workflows/cypress.yml b/.github/workflows/cypress.yml
index 60b95ee..e3bd0f5 100644
--- a/.github/workflows/cypress.yml
+++ b/.github/workflows/cypress.yml
@@ -26,7 +26,7 @@ jobs:
 
     - name: "Install galaxykit dependency"
       run: |
-        pip install galaxykit
+        pip install git+https://github.com/ansible/galaxykit.git
 
     - name: "Set env.SHORT_BRANCH, env.GALAXY_NG_COMMIT"
       run: |

(looks like ansible/galaxykit#20 was merged Dec 23, but the latest release is from Dec 1st)

Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

And I think we can keep pip installing from github on master without problems,
only stable-* branches should probably depend on released versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants