Unify success alerts #1469

ShaiahWren · 2022-01-07T22:50:38Z

See issue: https://issues.redhat.com/browse/AAH-1236

Assignment: Update success alerts to fit modular format outlined in the documentation. Also see additional documentation for general messages.

This pr updates all alerts messages across the application according to the above documentation. In some cases, missing alerts were added.

brumik

In global looks good, but I have concerns regarding to the translation. See the comments bellow.

src/containers/certification-dashboard/certification-dashboard.tsx

src/containers/execution-environment-detail/base.tsx

src/containers/execution-environment-list/execution_environment_list.tsx

src/containers/settings/user-profile.tsx

src/containers/task-management/task-list-view.tsx

src/components/delete-modal/delete-execution-environment-modal.tsx

src/containers/edit-namespace/edit-namespace.tsx

src/containers/certification-dashboard/certification-dashboard.tsx

test/cypress/integration/collection.js

src/containers/task-management/task-list-view.tsx

src/containers/task-management/task_detail.tsx

src/containers/settings/user-profile.tsx

src/containers/namespace-detail/namespace-detail.tsx

src/components/headers/collection-header.tsx

src/containers/execution-environment-detail/base.tsx

src/containers/execution-environment-detail/execution_environment_detail_images.tsx

src/containers/execution-environment/registry-list.tsx

src/containers/group-management/group-list.tsx

CHANGES/1236.task

himdel · 2022-01-12T00:07:46Z

@ShaiahWren you may have missed some ... Successfully deleted user. in delete-user-modal is unchanged, probably belongs here as well?

(Are you splitting the effort in multiple PRs or should I try checking for more missing success messages?)

ShaiahWren · 2022-01-12T21:43:34Z

@himdel AlertType now accepts JSXElement or string for the title, however, as you can see the bold doesn't seem to be showing up in the alerts. Is it my syntax?

I will continue to work on the other items. Thank you for the thorough review. :)

Issue: AAH-1236

noticed in ansible#1738, looks like this was introduced in ansible#1469 to replace "Successfully deleted collection." we're now using the same success message in `deleteCollection` and `deleteCollectionVersion`, which is misleading (they didn't just delete one version), and broken since there is no version info, just the `v` updating to remove the version info

noticed in ansible#1738, looks like this was introduced in ansible#1469 to replace "Successfully deleted collection." we're now using the same success message in `deleteCollection` and `deleteCollectionVersion`, which is misleading (they didn't just delete one version), and broken since there is no version info, just the `v` updating to remove the version info No-Issue

* deleteCollection - don't mention version when deleting the whole noticed in #1738, looks like this was introduced in #1469 to replace "Successfully deleted collection." we're now using the same success message in `deleteCollection` and `deleteCollectionVersion`, which is misleading (they didn't just delete one version), and broken since there is no version info, just the `v` updating to remove the version info No-Issue * collection.js test - fix expected alert message to match

ShaiahWren force-pushed the unify-success-alerts branch from 68a1946 to b39e900 Compare January 10, 2022 16:21

ShaiahWren requested a review from himdel January 10, 2022 16:51

ShaiahWren force-pushed the unify-success-alerts branch 3 times, most recently from 499bdd0 to f12761b Compare January 10, 2022 22:56

brumik previously requested changes Jan 11, 2022

View reviewed changes

ShaiahWren force-pushed the unify-success-alerts branch from 22a8956 to f53783d Compare January 11, 2022 17:50

ShaiahWren requested a review from brumik January 11, 2022 19:16