Fix indent of the groupped toolbar

[brumik]

Issue: https://issues.redhat.com/browse/AAH-822

Concern about the change

If we edit these pages (merge this PR), then the toolbar indent is not matching to the "Approval" and "User access" page's toolbar (Where they have this indent).

Before

Result

[brumik]

If we edit these pages (merge this PR), then the toolbar indent is not matching to the "Approval" and "User access" page's toolbar (Where they have this indent).

Taufique Rahman approved and we may raise this issue to the PF team.

Good to merge

[himdel]

If we edit these pages (merge this PR), then the toolbar indent is not matching to the "Approval" and "User access" page's toolbar (Where they have this indent).

Those should also be fixed, I believe the goal was to fix all toolbars to align with the header.
(The issue is from July, we didn't have Execution Environments nor Task Management back then)

But up to you if you want to keep this one short and deal with the rest separately :)

[brumik]

@himdel I looked into that issue and found the global solution for it. It was a random pf class overwrite in a scss affecting every page. Ideally we should not overwrite pf classes in scss. (In fact I am a big fan of styled-components since it encapsulates the styling and makes these kinds of problems disapear :)

Anyway: I feel like your concerns on this PR are answered. Another round of review?

[himdel]

OK, looks like we need to keep the class override for now, this now breaks the alignment on those screens...

[brumik]

It would have been helpful to get full screenshots so I know where is this occurring. We can overwrote them one by one rather than overriding the pf class and then override it back on places where we don't need it.

Edit: the toolbar actually should more or less look like we have, we have more overrides. Let me go trough them.

[brumik]

I modified most of the toolbars to:

1. Keep the current looks and the fixed paddings
2. Use minimal scss and custom styling and follow the PF library as close as possible.

This modification included

1. making the custom css to PF
2. put the pagination into the toolbar
3. put the chips under the toolbar while keeping in the toolbar (will help in the future when starting to use PF automatic chips)

All the modified toolbars are visible in the screenshots under.

Followup task could be:

1. make the chips under the toolbar use the default patternfly builtin functions instead of hacking it under the toolbar by ourselves. (If I get the time I would like to work on this.)

[himdel]

So, the original change was really close, this now seems overly ambitious for that particular bug, especially since we may want to backport the fix.

Can you split this into 2 separate PRs please? Or just revert back to the original fix for Collections, without affecting the rest of the application.

---

More specifically, this now seems to be introducing quite some extra whitespace in both layouts...

	master	here
empty
filtering

Apart from fixing AppliedFilters alignment in Remote Registries :)...

	master	here
empty
filtering

[brumik]

@himdel Ill do a quick fix then and leave this on the side.

The filter spacing can be not so easily fixed by using the built in filters in the PF Toolbar component.
When I do these changes I can redo that part too, but that's a bit bigger refactor (I am happy to undertake but may take up more time so I need somebody approval that I can work on it)

[brumik]

For the current state look at the PR description.