Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added l10n translation cypress tests #1494

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Added l10n translation cypress tests #1494

merged 1 commit into from
Jan 20, 2022

Conversation

brumik
Copy link
Contributor

@brumik brumik commented Jan 11, 2022 •
edited by himdel

@brumik brumik requested a review from himdel January 11, 2022 12:01
@brumik brumik force-pushed the brumik-l10n-cypress-tests-AAH-1189 branch 2 times, most recently from 4c44af6 to bbfd066 Compare January 11, 2022 12:19
@himdel
Copy link
Collaborator

himdel commented Jan 11, 2022 •
edited

Overall looks great 👍

I wonder if we should also add a test for Namespaces (once #1495 is in), given these would also cover testing lazy-translated strings.

@brumik
Copy link
Contributor Author

brumik commented Jan 12, 2022

@himdel We can merge this first I think and then we can add the tests in #1495 keeping the whole issue in one PR. (It seems like that PR is going to be merged slower than this could be)

@brumik brumik force-pushed the brumik-l10n-cypress-tests-AAH-1189 branch from bbfd066 to cade27c Compare January 12, 2022 09:55
@himdel
Copy link
Collaborator

himdel commented Jan 14, 2022 •
edited

We can merge this first I think and then we can add the tests in #1495

I'm fine with that 👍
Just remember to keep AAH-1189 open until #1495 is merged with tests.

However that may be a moot point, this is also still missing the API string tests.

@brumik
Copy link
Contributor Author

brumik commented Jan 14, 2022 •
edited

The API tests are still WIP, still tracking down why I cannot see them properly in manual testing :)

https://ansible.slack.com/archives/C0269FV71PX/p1642150969002300

@brumik brumik marked this pull request as draft January 14, 2022 08:20
@brumik
Copy link
Contributor Author

brumik commented Jan 18, 2022 •
edited

@himdel The API translations in POST request when catching an error is not working, and could not find any other places to test API translations with GET.

I suggest we merge these tests in, then create separate tests for the API translations, which we could track in a separate ticket and all.

https://issues.redhat.com/browse/AAH-1281

^ After asking help from @ jctanner

@brumik brumik marked this pull request as ready for review January 18, 2022 16:35
@himdel
Copy link
Collaborator

himdel commented Jan 20, 2022

Agreed, thanks, approved :)

@brumik brumik merged commit 79e1a72 into master Jan 20, 2022
@brumik brumik deleted the brumik-l10n-cypress-tests-AAH-1189 branch January 20, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brumik @himdel