Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the localization of the Namespaces string #1525

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Fixed the localization of the Namespaces string #1525

merged 1 commit into from
Jan 20, 2022

Conversation

brumik
Copy link
Contributor

@brumik brumik commented Jan 17, 2022

Issue: AAH-1069

Before
Screenshot from 2022-01-17 10-51-15

After
Screenshot from 2022-01-17 10-50-11

@brumik brumik requested a review from himdel January 17, 2022 09:51
@brumik brumik mentioned this pull request Jan 17, 2022
Closed
himdel
himdel approved these changes Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both strings are marked for translation, works for me 👍

I'm slightly worried that using t`..` + i18n._ could lead to double translation if the t bit ever starts translating that, but we can use defineMessage once all callers are converted.

Thanks :)

@brumik brumik merged commit a58925d into ansible:master Jan 20, 2022
@brumik brumik deleted the fixing-namespace-translation branch January 20, 2022 09:03
@himdel himdel added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Jan 20, 2022
@patchback
Copy link

patchback bot commented Jan 20, 2022 •
edited

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/a58925d77e44b6663127a2ac90e23c03e769bf8c/pr-1525

Backported as #1530

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 20, 2022
@brumik @patchback
Fixed the localization of the Namespaces string (#1525)
8d2b335 
Issue: AAH-1069
(cherry picked from commit a58925d)
@patchback patchback bot mentioned this pull request Jan 20, 2022
Merged
himdel pushed a commit that referenced this pull request Jan 20, 2022
@patchback @brumik
Fixed the localization of the Namespaces string (#1525) (#1530)
ebd5348 
Issue: AAH-1069
(cherry picked from commit a58925d)

Co-authored-by: Levente Berky <levente.berky@gmail.com>
@github-actions github-actions bot added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

Assignees
No one assigned
Labels
backport-4.4 This PR should be backported to stable-4.4 (2.1) backported-4.4 This PR has been backported to stable-4.4 (2.1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brumik @himdel