pr-checks: add webpack-config check for changes in webpack config #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're relying on frontend-components-config to generate parts of our webpack config, it can be useful to watch out for changes in that generated config on PRs. A detected change is not a reason to not merge PRs when intentional, but this should make it easier to notice any such changes, and check that any intended changes don't have unintended side effects for other modes and configs. This just checks out the PR and the base branch, imports the individual webpack config files, dumps them as json, and diffs the result :). No-Issue
…fference (master vs HEAD)
MilanPospisil
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're relying on frontend-components-config to generate parts of our webpack config,
it can be useful to watch out for changes in that generated config on PRs.
A detected change is not a reason to not merge PRs when intentional, but this should make it easier to notice any such changes,
and check that any intended changes don't have unintended side effects for other modes and configs.
This just checks out the PR and the base branch, imports the individual webpack config files, dumps them as json, and diffs the result :).
Before diffing, we normalize filenames (
/home/runner/work/ansible-hub-ui/ansible-hub-ui/base/->/DIR/), timestamps (js/[name].1643247060362.[fullhash].js->js/[name].TIMESTAMP.[fullhash].js), and removeCurrent branch:because we're comparingmasterwithHEAD:).How this looks with errors: https://github.com/ansible/ansible-hub-ui/runs/4960316969?check_suite_focus=true#step:5:99