Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github container registry instead of docker #1562

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Conversation

fao89
Copy link
Contributor

@fao89 fao89 commented Jan 26, 2022

No-Issue

Thank you for a new Pull Request!

Please, make reviewers work easier by checking, if you are not introducing any technical debt:
https://github.com/ansible/ansible-hub-ui/blob/master/developer_guidelines.md

Describe the rationale and use case for this pull request. Provide any background, examples, and images that provide further information to accurately describe what it is that you are adding to the repo. Add subsections as necessary to organize and feel free to link and reference other PRs as necessary, but also include them in the links section below as a quick reference.

Guidelines:

  • Keep Pull Request titles short and to the point, ideally under 72 characters
  • Provide as much context/info in the description as necessary to get the reviewer up to the same domain knowledge level as yourself
  • Keep code changes as short as possible and implementing a single feature/fix/refactoring, when possible

Links [Optional]

Steps for Testing/QA [Optional]

If there are any manual steps that you would like the reviewer(s) to take to verify your changes, please describe in detail the steps to reproduce the features added by the pull request, or the bug before and after the change.

@fao89 fao89 requested a review from himdel January 27, 2022 12:02
Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! :)

@fao89 fao89 merged commit 0803999 into ansible:master Jan 27, 2022
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Aug 29, 2022
himdel added a commit that referenced this pull request Sep 1, 2022
* cypress.yml - backport changes from master

Backports cypress.yml changes from #2480, #2478, non-signing parts of #2240, #1979, #2233, #1827, #1558, #1562, #1323

No-Issue

* build from pulp-ci-centos 3.15, not latest (current 4.4 uses pulpcore==3.15.8)

* galaxykit collection list -> namespace list

collection list doesn't exist in 0.7.0 yet (also #2265)

* pulpPrefix - set to /pulp/api/v3/

not API_BASE_PATH + /pulp/api/v3/ .. that's 4.6+

(also reformat, but skip the rest of #1651)

* update cache key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants