Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1295/28727815 backport][stable-4.4] Fix translation in repo selector #1563

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jan 27, 2022

This is a backport of PR #1295 as merged into master (2872781).

Issue: AAH-1070

Strings that are marked for translation don't seem to be working if imported from a different file. This is fixed by returning the string in the function and then evoking the function in component. Not sure this is the right way, I couldn't find any mention about this in the Lingui documentation, wdyt @himdel ?

  static REPOSITORYNAMES = {
    published: () => t`Published`,
    'rh-certified': () => t`Red Hat Certified`,
    community: () => t`Community`,
  };

before:
Screenshot from 2021-11-24 16-26-49

after:
Screenshot from 2021-11-24 16-11-32

* fix repo selector string translating

* remove getValFromFnc util

* use defineMessage for constant translation

* add translation of tasks

* fix translation in task_detail page

* fix translations

* rewrite to clearer statement

Issue: AAH-1070
(cherry picked from commit 2872781)
@himdel himdel merged commit 377514a into stable-4.4 Feb 2, 2022
@himdel himdel deleted the patchback/backports/stable-4.4/2872781590ab7b8fdcd6a460d0cd016a8a5476cb/pr-1295 branch February 2, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants