add env variable to dockerfile #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No-Issue
newswangerd
approved these changes
Jan 31, 2022
himdel
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
I can't reproduce the failures locally, but this looks like the right fix as long as you're running the UI this way in docker 👍
Only... https://nodejs.org/api/cli.html#--max-old-space-sizesize-in-megabytes mentions max-old-space-size instead of max_old_space_size.
But if you're sure this works for you with underscores, no objections :)
ShaiahWren
deleted the
add-env-variable-to-dockerfile-to-increase-memory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No-Issue
This pr adds a new ENV variable in the dockerfile to increase memory and minimize crashes due to limited space.