[stable-4.4] CollectionContentList - fix by type counts being 0 when All not chosen (#1577) #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansible#1577) go to Collection detail, tab Contents the "Showing: All(23) Role(9) Module(3) Action(1) Filter(8) Test(2)" line only shows correct counts when All is selected, otherwise only the current type is counted, leaving other types at 0, because filtering is done by both keyword and type, before counting and showing the list this changes the code to first filter by keyword, then count, then filter by type, then show No-Issue (cherry picked from commit 7e48ccf) Fixes AAH-1334
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #1577, const vs let difference.
Fixes AAH-1334
go to Collection detail, tab Contents
the "Showing: All(23) Role(9) Module(3) Action(1) Filter(8) Test(2)" line only shows correct counts when All is selected,
otherwise only the current type is counted, leaving other types at 0,
because filtering is done by both keyword and type, before counting and showing the list
this changes the code to first filter by keyword, then count, then filter by type, then show
No-Issue
(cherry picked from commit 7e48ccf)