-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Signing 2] Add only signed options to remote form #1625
Conversation
brumik
commented
Feb 9, 2022
•
edited
edited
- There is maybe a need to add a sign that repo is syncs only signed only
- Waiting for more info here: https://issues.redhat.com/browse/AAH-1333
- Api does not supports it yet, by chat conversation we will not implement this now.
@brumik Is this ready for review?
Maybe this needs to be better marked "to not be reviewed" :) WIP in title or making it a draft. |
@ZitaNemeckova this PR is ready. That particular feature can come later when api supports it. |
@brumik Right now I can say it looks good code-wise 👍 BUT it's impossible to test without API and definetely shouldn't be merged because it breaks the form rigth now if an user changes the value of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Api does not supports it yet, by chat conversation we will not implement this now.
Is this still relevant?
@himdel Yes, we will card it up probably now. |
What does this mean? That sounds like "yes, we're not doing this" but if so, why the merge? As per Bruno: API supports and exposes that field, we must be able to set a remote to sync only signed content So sounds like this should be merged 👍, treating as done. @brumik when you're back, please clarify if there are any missing parts, or if you still have any concerns regarding API support. EDIT: the missing parts are probably in a separate issue now - https://issues.redhat.com/browse/AAH-1476 |
…, not registries Follow-up to ansible#1625 the new switch was also visible for remoteType=registry, hiding No-Issue
…, not registries (#1864) Follow-up to ansible/ansible-hub-ui#1625 the new switch was also visible for remoteType=registry, hiding No-Issue
…, not registries (#1864) Follow-up to ansible/ansible-hub-ui#1625 the new switch was also visible for remoteType=registry, hiding No-Issue
Thanks for the merge, yes, the missing part is moved to a separate issue. |