Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Signing 2] Add download signature item #1627

Merged
merged 1 commit into from
Mar 22, 2022
Merged

[Signing 2] Add download signature item #1627

merged 1 commit into from
Mar 22, 2022

Conversation

brumik
Copy link
Contributor

@brumik brumik commented Feb 9, 2022

Screenshot from 2022-02-09 10-03-48
Screenshot from 2022-02-09 10-03-39

@brumik brumik requested a review from himdel February 9, 2022 09:06
@brumik brumik mentioned this pull request Feb 9, 2022
2 tasks
@brumik brumik changed the title [Signing 2] Add download signature item [Signing 2] Add download signature item [WAIT FOR API] Mar 2, 2022
@brumik brumik changed the title [Signing 2] Add download signature item [WAIT FOR API] [Signing 2] Add download signature item Mar 3, 2022
@himdel
Copy link
Collaborator

himdel commented Mar 8, 2022

the expand signature button works, but the signature is mistreating whitespace, I think you need white-space: pre; (or pre-wrap) on that element: (there should be a visible newline after BEGIN PGP SIGNATURE-+, and before -+END)

(collection-detail.scss already does it for pre but not for code)

@brumik
Copy link
Contributor Author

brumik commented Mar 9, 2022

Thank you. I was lazy here initially. I updated it to use PF components (which displaying it correctly)
Screenshot from 2022-03-09 14-56-00

@brumik brumik requested a review from himdel March 9, 2022 13:56
@brumik brumik merged commit 9125c27 into ansible:master Mar 22, 2022
@brumik brumik deleted the add-download-signature-field branch March 22, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants