[Signing 2] Add sign and approve to dashboard #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brumik
commented
Feb 9, 2022
•
brumik
commented
brumik
changed the title
himdel
reviewed
Mar 3, 2022
| @@ -364,6 +362,11 @@ class CertificationDashboard extends React.Component< | |||
| } | |||
|
|
|||
| private renderButtons(version: CollectionVersion) { | |||
| const canSign = | |||
| this.context.featureFlags.collection_signing === true && | |||
| this.context.featureFlags.collection_auto_sign === true && | |||
There was a problem hiding this comment.
this is probably wrong, being able to Sign a collection should not depend on autosigning, just signing
There was a problem hiding this comment.
@himdel Maybe the canSign naming is confusing, but this says: if you approve & you can sign & it will sign on approve then isntead of Approve we display Sign and Approve. Any other case it is just an Approval.
Is there perhaps a specific PR this is waiting on? :) |
brumik
changed the title
|
@himdel I just making another round of checks to make sure it works without the signing PR on the backed. This one now should be good to go without the backend changes in. |
himdel
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.