Part II: Unify fail alerts #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaiahWren
force-pushed
the
unify-fail-alerts-part-II
branch
from
3fd3347
to
7a066dd
Compare
ShaiahWren
commented
Feb 16, 2022
ShaiahWren
commented
Feb 16, 2022
himdel
reviewed
Feb 22, 2022
src/containers/certification-dashboard/certification-dashboard.tsx
Outdated
Show resolved
Hide resolved
ShaiahWren
force-pushed
the
unify-fail-alerts-part-II
branch
from
7a066dd
to
07dacaf
Compare
himdel
reviewed
Feb 28, 2022
| @@ -120,7 +120,7 @@ export class NamespaceForm extends React.Component<IProps, IState> { | |||
| formErrors: { | |||
| ...this.state.formErrors, | |||
| groups: { | |||
| title: t`Error loading groups.`, | |||
| title: t`Groups list could not be displayed.`, | |||
| description: err, | |||
There was a problem hiding this comment.
so, err in ObjectPermissionField onError is the same as err?.message elsewhere .. should this therefore also use errorMessage?
(You'll also need to
--- a/src/components/permissions/obect-permission-field.tsx
+++ b/src/components/permissions/obect-permission-field.tsx
@@ -123,2 +123,2 @@ export class ObjectPermissionField extends React.Component<IProps, IState> {
- .catch((e) => this.props.onError(e?.message));
+ .catch((e) => this.props.onError(e));to make it work.)
himdel
reviewed
Feb 28, 2022
| @@ -176,7 +176,7 @@ export class NamespaceModal extends React.Component<IProps, IState> { | |||
| formErrors: { | |||
| ...this.state.formErrors, | |||
| groups: { | |||
| title: t`Error loading groups.`, | |||
| title: t`Groups list could not be displayed.`, | |||
| description: err, | |||
There was a problem hiding this comment.
himdel
reviewed
Feb 28, 2022
| this.setState({ | ||
| formErrors: { | ||
| ...this.state.formErrors, | ||
| groups: { | ||
| title: t`Error loading groups.`, | ||
| title: t`Groups list could not be displayed.`, | ||
| description: err, |
There was a problem hiding this comment.
himdel
reviewed
Feb 28, 2022
ShaiahWren
force-pushed
the
unify-fail-alerts-part-II
branch
2 times, most recently
from
2708746
to
70c90cf
Compare
Issue: AAH-1354
Issue: AAH-1354
Issue: AAH-1354
Issue: AAH-1354
Issue: AAH-1354
ShaiahWren
force-pushed
the
unify-fail-alerts-part-II
branch
from
70c90cf
to
3ff186c
Compare
|
@himdel Done, though I had to change |
ZitaNemeckova
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/AAH-1354
This pr works towards unifying fail alert notifications across the application. The effort will be broken into several prs.
Please reference this working document for a list of target notifications.