Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub-4.4.0dev] Execution Environments > alpine > Activity, the (last) string 'was added' needs to be marked as translatable string #1679

Merged
merged 1 commit into from
Feb 22, 2022
Merged

[Hub-4.4.0dev] Execution Environments > alpine > Activity, the (last) string 'was added' needs to be marked as translatable string #1679

merged 1 commit into from
Feb 22, 2022

Conversation

MilanPospisil
Copy link
Contributor

Issue: AAH-1205

https://issues.redhat.com/browse/AAH-1205

While in Japanese google-chrome, do following:

Add a new Execution Evironment say name is 'alpine'
Upstream name say 'libpod/alpine'
Registry 'Quay'
Tags to include 'latest'
Hit 'Save'
Later do 'Sync from registry'
Visit Execution Environments > alpine > Activity
Observe the (last) string 'was added'

'was added' need to be marked as translatable string.

@himdel himdel added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Feb 21, 2022
@himdel
Copy link
Collaborator

himdel commented Feb 22, 2022

Tested with localStorage.test_l10n = true 👍 :

20220222003243

@himdel himdel mentioned this pull request Feb 22, 2022
Merged
@MilanPospisil MilanPospisil merged commit f2cddc4 into ansible:master Feb 22, 2022
@patchback
Copy link

patchback bot commented Feb 22, 2022 •
edited

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/f2cddc4e8c69cff120a09c014e3915ef265bb5d8/pr-1679

Backported as #1683

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 22, 2022
@MilanPospisil @patchback
Added translations to EE->Activities Repository was added (#1679)
fd13fbc 
Issue: AAH-1205
(cherry picked from commit f2cddc4)
@patchback patchback bot mentioned this pull request Feb 22, 2022
Merged
himdel pushed a commit that referenced this pull request Mar 4, 2022
@patchback @MilanPospisil
Added translations to EE->Activities Repository was added (#1679) (#1683
21e1621 
)

Issue: AAH-1205
(cherry picked from commit f2cddc4)

Co-authored-by: MilanPospisil <arkanus@seznam.cz>
@github-actions github-actions bot added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

Assignees
No one assigned
Labels
backport-4.4 This PR should be backported to stable-4.4 (2.1) backported-4.4 This PR has been backported to stable-4.4 (2.1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MilanPospisil @himdel