Fix incorrect uses of aria-labelledby, replace with data-cy
#1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For providing an ARIA title inline, use `aria-label`, `aria-labelledby` should point to an `id` of a DOM element providing an actual title. ..but we only use it that way for `markdown-title` in `MarkdownEditor`. The rest of uses should really be `data-cy`, or are unused now. We also want to make sure those `data-cy` attributes are unique enough to be searchable - adding the component name where appropriate. No-Issue
and drop unused readonly-auth
…table_header ```diff - [data-cy="table_header"] - [aria-labelledby="headers"] + [data-cy="SortTable-headers"] ``` mostly just `perl -i -npe 's/aria-labelledby=.headers./data-cy="SortTable-headers"/' test/cypress/integration/*js`
ZitaNemeckova
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For providing an ARIA title inline, use
aria-label,aria-labelledbyshould point to anidof a DOM element providing an actual title.... but we only use it that way for
markdown-titleinMarkdownEditor.The rest of uses should really be
data-cy, or are unused now.We also want to make sure those
data-cyattributes are unique enough to be searchable - adding the component name where appropriate.(since Friday was an accessibility themed learning day :))