Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for sporadic failures 2 (group_management, execution_environments_use_in_controller.) #1707

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

MilanPospisil
Copy link
Contributor

@MilanPospisil MilanPospisil commented Mar 1, 2022

Issue: AAH-1410

Focus mostly on execution_enviroments_use_in_controller.js. It tries to repair it - it now waits for the delete task to be completed (delete user command).

And it repairs also group management - there is new error due to alert PR. New alerts now contains name of the user and the test had very bad selector (no selector) that searches the user name at the whole page (for not contains). It worked before, but now the alert also contains the user name and it wrongly finds it there and fail.

@MilanPospisil MilanPospisil changed the title Search for sporadic failures 2 Search for sporadic failures 2 (group_management, execution_environments_use_in_controller.) Mar 3, 2022
@@ -625,6 +625,9 @@ Cypress.Commands.add('syncRemoteContainer', {}, (name) => {
'.pf-c-alert__title',
`Sync started for execution environment "${name}".`,
);
// wait for finish
cy.contains('a', 'detail page').click();
cy.contains('.title-box h1', 'Completed', { timeout: 20000 });
Copy link
Collaborator

@himdel himdel Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 .. but I agree this fixes the problem for now 👍

Definitely a FIXME for later though, seems like now that we know sync sometimes takes longer than the usual timeouts, we can fix it properly too...

20220307021415

we can wait for the alert, click that "detail page" link, land on a task detail...

20220307021423

and that page auto-updates to say Complete when done.

EDIT: oh, it already does that, and still needs the extra timeout .. oh well, nothing we can do for now, we'll probably need to sync from a local registry or something like that

@himdel
Copy link
Collaborator

himdel commented Mar 7, 2022

Restarting tests just to make sure :)

@himdel himdel closed this Mar 7, 2022
@himdel himdel reopened this Mar 7, 2022
@himdel
Copy link
Collaborator

himdel commented Mar 7, 2022

Merging, this fixes the group_management failure that's now happening everywhere 👍

But, see the failure here, execution_environment_use_in_controller is still failing sporadically.
(And so is collection_upload)

@himdel himdel merged commit 57c369f into ansible:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants