Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group list and detail view parity #1717

Merged

Conversation

ShaiahWren
Copy link
Contributor

@ShaiahWren ShaiahWren commented Mar 4, 2022

Issue: https://issues.redhat.com/browse/AAH-1088
This pr makes cosmetic changes to group detail and list views, making sure that kebab dropdown for edit and delete functions are moved to the far right of table. Also see changes to the wording on remove user from group modal to match UX models implemented elsewhere on the app (see alerts notifications).

  • list view delete button (toggle dropdown) is moved to the right

  • detail view delete button (toggle) is moved to the right

  • Confirmed: group detail has edit, delete, and add/remove functions

  • Confirmed: group list has delete and edit buttons (toggle dropdown)

Before:
-List
Screen Shot 2022-03-04 at 1 51 14 PM
-detail
Screen Shot 2022-03-04 at 1 52 15 PM

After:
-list
Screen Shot 2022-03-04 at 1 51 35 PM
-detail
Screen Shot 2022-03-04 at 1 55 24 PM

@ShaiahWren ShaiahWren requested a review from himdel March 4, 2022 19:50
@himdel himdel closed this Mar 7, 2022
@himdel himdel reopened this Mar 7, 2022
Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me :)

@ShaiahWren
Copy link
Contributor Author

Pr closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants