Fix EE detail Edit when include_tags not an array #1736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a remote execution environmnent and then editing it already works (as the UI will always send
include_tags: [], exclude_tags: []
when not set).But creating one through the API, you can skip include_tags or exclude_tags without getting a validation error.
After that, editing that EE only works from the list screen, but yields a blank screen when editing from the detail screen.
Fixing by adding a
|| []
to the detail screen as well.No-Issue
(corresponding code in list screen edit: https://github.com/ansible/ansible-hub-ui/blob/master/src/containers/execution-environment-list/execution_environment_list.tsx#L433-L434 )