Signing - update API endpoint, permission checking #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
himdel
commented
Apr 6, 2022
…permissions ui-side the alternative would be to add this to CollectionVersionAPI, or change to a modal that checks per namespace
himdel
force-pushed
the
updating-signing-endpoint
branch
from
9c94441
to
e0d3860
Compare
|
Needs ansible/galaxy_ng#1188 . Without that it uploaded a collection to |
ZitaNemeckova
approved these changes
Apr 7, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on
ansible/galaxy_ng#1197ansible/galaxy_ng#1188(Also on merged ansible/galaxy_ng#1145)
Replaces #1801, taking the work from there and finishing the
canSignlogic using the nearestnamespace.related_fields.my_permissions.testing:
no need for custom pulp-ansible here, but depends on ansible/galaxy_ng#1188
setting env vars for signing example in ansible/galaxy_ng#1197 (comment)