Update to use v3 apis instead of legacy ; collection test fix #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging now, to get tests in master, stable-4.5 and feature/rbac-roles green again, |
Backport to stable-4.5: 💚 backport PR created✅ Backport PR branch: Backported as #1976 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 25, 2022
* Update to use v3 apis instead of legacy ; collection test fix from https://github.com/pulp/pulp_ansible/blob/main/pulp_ansible/app/urls.py#L43 No-Issue * fix collection-list test in galaxykit ansible/galaxykit#42 (cherry picked from commit 5ff76b6)
himdel
added a commit
that referenced
this pull request
Apr 25, 2022
* Update to use v3 apis instead of legacy ; collection test fix from https://github.com/pulp/pulp_ansible/blob/main/pulp_ansible/app/urls.py#L43 No-Issue * fix collection-list test in galaxykit ansible/galaxykit#42 (cherry picked from commit 5ff76b6)
himdel
added a commit
that referenced
this pull request
Apr 25, 2022
…#1976) * Update to use v3 apis instead of legacy ; collection test fix from https://github.com/pulp/pulp_ansible/blob/main/pulp_ansible/app/urls.py#L43 No-Issue * fix collection-list test in galaxykit ansible/galaxykit#42 (cherry picked from commit 5ff76b6) Co-authored-by: Martin Hradil <mhradil@redhat.com>
github-actions
bot
added
the
backported-4.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates us to use the new v3/plugin/ansible urls for collection deletion, deprecation and download urls,
updates the test to wait for the right request/response.
(redirects from https://github.com/pulp/pulp_ansible/blob/main/pulp_ansible/app/urls.py#L43)
This should fix the
collection.jstest failure:https://github.com/ansible/ansible-hub-ui/runs/6152044308?check_suite_focus=true#step:17:249
Also updating galaxykit to ansible/galaxykit#42 to fix the
collection-list.jstest failure:https://github.com/ansible/ansible-hub-ui/runs/6152044308?check_suite_focus=true#step:17:312