Error messages aren't displaying on the remote container create form #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e form Issue: AAH-1845 PR Checks PR checks
MilanPospisil
force-pushed
the
addEEErrorMessageDuplicateName-AAH-1845
branch
from
48501e2
to
e6d2343
Compare
himdel
reviewed
Aug 17, 2022
|
|
||
| return ( | ||
| nameError && ( | ||
| <Alert title={nameError.title} variant='danger' isInline> |
There was a problem hiding this comment.
so, these are eseentially validation errors, right?
We're usually using code like
<FormGroup
...
validated={this.toError(!('token' in errorMessages))}
helperTextInvalid={errorMessages['token']}
>
<TextInput
...
validated={this.toError(!('token' in errorMessages))}
with errorMessages: ErrorMessagesType that comes from mapErrorMessages(error).
formErrors is used here instead, that's probably fine (for now; also used in user-form, but nowhere else) but we should still be using helperTextInvalid instead of an inline alert, unless there's an actual error
(this is also missing a screenshot, so I'm only guessing these are validation errors?)
There was a problem hiding this comment.
Ok, I will try to use your way.
newswangerd
reviewed
Aug 23, 2022
| @@ -207,6 +208,7 @@ export class RepositoryForm extends React.Component<IProps, IState> { | |||
| onChange={(value) => this.setState({ name: value })} | |||
| validated={this.validateName(name)} | |||
| /> | |||
| {this.renderNameError(formError)} | |||
There was a problem hiding this comment.
This should check for errors on other fields too, not just "name"
|
(replaced with #2601) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/AAH-1845
Messages were in fact displayed, but at the bottom of the form and many users dont have the bottom displayed without scrolling. Those errors could be easily missed.
This PR added the error message right under the name field.
And it also repairs another mistake - errors were not cleared when modal closed (on success or cancel).
Issue: AAH-1845