Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error messages aren't displaying on the remote container create form #2601

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Error messages aren't displaying on the remote container create form #2601

merged 2 commits into from
Dec 14, 2022

Commits on Dec 13, 2022

  1. WIP

    @MilanPospisil
    MilanPospisil committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    010ddfc View commit details
    Browse the repository at this point in the history

  2. Repair forms validation in EE form. 

    Issue: 1845

Repair setState passing to function without lambda

PR checks
Issue: AAH-1845

Delete unecessary set functions in validation utility

PR review

Review - registry to registries

Use of form valid

Handle errors for registries and registry.

Log the rest of the errors. Catch promises on save in one place.

Alert the rest errors instead of displaying them.

Translate error string, show error only for unknown field, clear the error after showing alert

Add translation

Rename rest remoteId

PR review

Prettier

WIP

Prettier

Remove messages without field

Prettier

PR Checks

Review - rename remotePulpId and add type to isFieldValid function

Prettier

Change order of prop

WIP

WIP
    @MilanPospisil
    MilanPospisil committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    c3b3e00 View commit details
    Browse the repository at this point in the history