Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container permisions to group view. #335

Conversation

newswangerd
Copy link
Member

Screen Shot 2021-03-30 at 5 00 21 PM

@ZitaNemeckova
Copy link
Member

diff --git a/test/cypress/support/commands.js b/test/cypress/support/commands.js
index a7dfd14..c0de4d7 100644
--- a/test/cypress/support/commands.js
+++ b/test/cypress/support/commands.js
@@ -126,15 +126,15 @@ Cypress.Commands.add('removePermissions', {}, (groupName, permissions) => {
     cy.get(`[aria-labelledby=${groupName}] a`).click();
     cy.contains('button', 'Edit').click();
     permissions.forEach(permissionElement => {
-        // closes previously open dropdowns
-        cy.get('h1').click();
         if (permissionElement.permissions.length > 3) {
             // Make sure all permissions are visible
-            cy.containsnear(`.pf-l-flex.pf-m-align-items-center.${permissionElement.group} `, '1 more').first().click();
+            cy.containsnear(`.pf-l-flex.pf-m-align-items-center.${permissionElement.group} `, 'more').first().click();
         }
         permissionElement.permissions.forEach(permission => {
             cy.containsnear(`.pf-l-flex.pf-m-align-items-center.${permissionElement.group} `, permission).findnear('button').first().click();
         });
+        // closes previously open dropdowns
+        cy.get('h1').click();
     });
     cy.contains('button', 'Save').click();
 });
@@ -149,6 +149,8 @@ const allPerms = [{
     group: 'groups', permissions: ['View group', 'Delete group', 'Add group', 'Change group']
 },{
     group: 'remotes', permissions: ['Change collection remote', 'View collection remote']
+},{
+    group: 'execution.environments', permissions: ['Change execution environment namespace permissions', 'Change execution environments', 'Change image tags', 'Pull private execution environments', 'View private execution environments']
 }];
 
 Cypress.Commands.add('removeAllPermissions', {}, (groupName) => {

Tests needs some minor updating like above. Otherwise LGTM 👍

@newswangerd newswangerd force-pushed the feature/AAH-254-container-model-permissions branch from 1809a5b to e846e2e Compare April 9, 2021 17:53
@newswangerd newswangerd merged commit d203332 into ansible:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants