Add a 404 Dispatch page, handle some old galaxy URLs #4090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
backport-4.7
himdel
force-pushed
the
beta-url-2342
branch
4 times, most recently
from
11482bb
to
badb824
Compare
old galaxy UI base path is /, /{namespace}/{name}/ is a valid old galaxy URL
new galaxy UI base path is /ui/, and URLs for collections are different from URLs for legacy roles
we still want to support old URLs, so, when navigating to `(new-galaxy)/foo/bar/`:
* backend will just serve the UI for unknown urls
* UI entry-standalone will notice URLs outside the `/ui/` base path, and redirect to `/ui/dispatch?pathname=/foo/bar`
* /dispatch is a new route, renders a 404-like Dispatch container
* Dispatch containers can query the APIs and show links to either the foo/bar collection or the foo/bar role, or both.
Issue: AAH-2342
This comment was marked as outdated.
This comment was marked as outdated.
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Aug 14, 2023
* Add a 404 Dispatch page, handle some old galaxy URLs
old galaxy UI base path is /, /{namespace}/{name}/ is a valid old galaxy URL
new galaxy UI base path is /ui/, and URLs for collections are different from URLs for legacy roles
we still want to support old URLs, so, when navigating to `(new-galaxy)/foo/bar/`:
* backend will just serve the UI for unknown urls
* UI entry-standalone will notice URLs outside the `/ui/` base path, and redirect to `/ui/dispatch?pathname=/foo/bar`
* /dispatch is a new route, renders a 404-like Dispatch container
* Dispatch containers can query the APIs and show links to either the foo/bar collection or the foo/bar role, or both.
Issue: AAH-2342
* fix Documentation link duplicate key
* list collections and roles, show as list items
* simplify standalone redirect
* add/use feature flags, links to all collections/role when none found
* dispatch empty state top bullseye
* dispatch - use EmptyStateNoData
(cherry picked from commit e0265b4)
himdel
added a commit
that referenced
this pull request
Aug 14, 2023
* Add a 404 Dispatch page, handle some old galaxy URLs
old galaxy UI base path is /, /{namespace}/{name}/ is a valid old galaxy URL
new galaxy UI base path is /ui/, and URLs for collections are different from URLs for legacy roles
we still want to support old URLs, so, when navigating to `(new-galaxy)/foo/bar/`:
* backend will just serve the UI for unknown urls
* UI entry-standalone will notice URLs outside the `/ui/` base path, and redirect to `/ui/dispatch?pathname=/foo/bar`
* /dispatch is a new route, renders a 404-like Dispatch container
* Dispatch containers can query the APIs and show links to either the foo/bar collection or the foo/bar role, or both.
Issue: AAH-2342
* fix Documentation link duplicate key
* list collections and roles, show as list items
* simplify standalone redirect
* add/use feature flags, links to all collections/role when none found
* dispatch empty state top bullseye
* dispatch - use EmptyStateNoData
(cherry picked from commit e0265b4)
github-actions
bot
added
the
backported-4.7
This was referenced Aug 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: AAH-2342
old galaxy UI base path is
/,/{namespace}/{name}/is a valid old galaxy URLnew galaxy UI base path is
/ui/, and URLs for collections are different from URLs for legacy roleswe still want to support old URLs, so, when navigating to
(new-galaxy)/foo/bar/:/ui/base path, and redirect to/ui/dispatch?pathname=/foo/bar/dispatchis a new route, renders a 404-likeDispatchcontainerDispatchcontainer can query the APIs and show links to either thefoo/barcollection or thefoo/barrole, or both.