Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote form: warn about signed_only enabled & missing requirements for Galaxy remote #4392

Merged
merged 1 commit into from Oct 16, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Oct 12, 2023

Issue: AAH-2748

also related to #4385 and thus AAH-2360

When editing the community remote (matched by Galaxy URL), warn about signed_only enabled and requirements_yaml empty.

Previously there were no warnings, these are valid settings that just don't work together with community galaxy.

20231012212659

…r Galaxy remote

Issue: AAH-2748

also related to ansible#4385 and thus AAH-2360
@github-actions github-actions bot added backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Oct 12, 2023
@himdel
Copy link
Collaborator Author

himdel commented Oct 12, 2023

Cc @nixocio , you may want to add these to ansible-ui Remotes in some form?

@himdel himdel merged commit cc0048c into ansible:master Oct 16, 2023
17 of 19 checks passed
@himdel himdel deleted the remote-community branch October 16, 2023 15:59
@patchback

This comment was marked as outdated.

@patchback
Copy link

patchback bot commented Oct 16, 2023

Backport to stable-4.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.8/cc0048ca12d22875ceef2fac16fe8f112b717760/pr-4392

Backported as #4407

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 16, 2023
…r Galaxy remote (#4392)

Issue: AAH-2748

also related to #4385 and thus AAH-2360

(cherry picked from commit cc0048c)
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Oct 16, 2023
…r Galaxy remote (ansible#4392)

Issue: AAH-2748

also related to ansible#4385 and thus AAH-2360

(cherry picked from commit cc0048c)
himdel added a commit that referenced this pull request Oct 16, 2023
…r Galaxy remote (#4392) (#4407)

Issue: AAH-2748

also related to #4385 and thus AAH-2360

(cherry picked from commit cc0048c)

Co-authored-by: Martin Hradil <mhradil@redhat.com>
@github-actions github-actions bot added the backported-4.8 This PR has been backported to stable-4.8 (2.4) label Oct 16, 2023
himdel added a commit that referenced this pull request Oct 16, 2023
…r Galaxy remote (#4392) (#4408)

Issue: AAH-2748

also related to #4385 and thus AAH-2360

(cherry picked from commit cc0048c)
@github-actions github-actions bot added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label Oct 16, 2023
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Oct 16, 2023
himdel added a commit that referenced this pull request Oct 16, 2023
patchback bot pushed a commit that referenced this pull request Oct 16, 2023
patchback bot pushed a commit that referenced this pull request Oct 16, 2023
himdel added a commit that referenced this pull request Oct 16, 2023
)

follows #4385, #4392

No-Issue

(cherry picked from commit 5b0a830)

Co-authored-by: Martin Hradil <mhradil@redhat.com>
himdel added a commit that referenced this pull request Oct 16, 2023
)

follows #4385, #4392

No-Issue

(cherry picked from commit 5b0a830)

Co-authored-by: Martin Hradil <mhradil@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4) backported-4.8 This PR has been backported to stable-4.8 (2.4)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant