New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote form: warn about signed_only enabled & missing requirements for Galaxy remote #4392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r Galaxy remote Issue: AAH-2748 also related to ansible#4385 and thus AAH-2360
github-actions
bot
added
backport-4.7
This PR should be backported to stable-4.7 (2.4)
backport-4.8
This PR should be backported to stable-4.8 (2.4)
labels
Oct 12, 2023
Cc @nixocio , you may want to add these to ansible-ui Remotes in some form? |
This comment was marked as outdated.
This comment was marked as outdated.
Backport to stable-4.8: 💚 backport PR created✅ Backport PR branch: Backported as #4407 🤖 @patchback |
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Oct 16, 2023
…r Galaxy remote (ansible#4392) Issue: AAH-2748 also related to ansible#4385 and thus AAH-2360 (cherry picked from commit cc0048c)
himdel
added a commit
that referenced
this pull request
Oct 16, 2023
github-actions
bot
added
the
backported-4.8
This PR has been backported to stable-4.8 (2.4)
label
Oct 16, 2023
himdel
added a commit
that referenced
this pull request
Oct 16, 2023
github-actions
bot
added
the
backported-4.7
This PR has been backported to stable-4.7 (2.4)
label
Oct 16, 2023
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Oct 16, 2023
himdel
added a commit
that referenced
this pull request
Oct 16, 2023
himdel
added a commit
that referenced
this pull request
Oct 16, 2023
himdel
added a commit
that referenced
this pull request
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-4.7
This PR should be backported to stable-4.7 (2.4)
backport-4.8
This PR should be backported to stable-4.8 (2.4)
backported-4.7
This PR has been backported to stable-4.7 (2.4)
backported-4.8
This PR has been backported to stable-4.8 (2.4)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: AAH-2748
also related to #4385 and thus AAH-2360
When editing the community remote (matched by Galaxy URL), warn about
signed_only
enabled andrequirements_yaml
empty.Previously there were no warnings, these are valid settings that just don't work together with community galaxy.