Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

Get module route for FQCN with more than 3 elements #538

Merged
merged 3 commits into from
Feb 13, 2023

Conversation

fredericgiquel
Copy link
Contributor

This PR completes the previous one (#449).

Last version of community.general use redirected module with more than 3 elements. This case is not handled properly. The redirected modules are seen in completion but without documentation and using the wrong category/kind. The problem can be seen in the following screenshot.
before

This PR fixes the problem and adds tests to detect it.

The result can be seen in the following screenshot.
after

Copy link
Contributor

@priyamsahoo priyamsahoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!
Looks good to me.

@priyamsahoo priyamsahoo added the bug Something isn't working label Feb 13, 2023
@priyamsahoo priyamsahoo merged commit b18f2f6 into ansible:main Feb 13, 2023
github-actions bot pushed a commit that referenced this pull request May 10, 2023
## v1.1.0

- Bump json5 from 2.2.1 to 2.2.3 (#539)

### Minor Changes

- Add variable auto-completion feature when cursor inside jinja inline brackets (#552) @priyamsahoo

### Bugfixes

- Get module route for FQCN with more than 3 elements (#538) @fredericgiquel
- Replace sphinx with mkdocs (#544) @ssbarnea
@ansibot ansibot mentioned this pull request May 10, 2023
github-actions bot pushed a commit that referenced this pull request Jun 5, 2023
## v1.0.5

### Minor Changes

- Add variable auto-completion feature when cursor inside jinja inline brackets (#552) @priyamsahoo

### Bugfixes

- Get module route for FQCN with more than 3 elements (#538) @fredericgiquel
- Replace sphinx with mkdocs (#544) @ssbarnea
- Bump json5 from 2.2.1 to 2.2.3 (#539)
@ansibot ansibot mentioned this pull request Jun 5, 2023
github-actions bot pushed a commit that referenced this pull request Jun 22, 2023
## v1.1.0

### Minor Changes

- Update yaml to 2.x (#566) @priyamsahoo
- Add variable auto-completion feature when cursor inside jinja inline brackets (#552) @priyamsahoo

### Bugfixes

- Get module route for FQCN with more than 3 elements (#538) @fredericgiquel
- Replace sphinx with mkdocs (#544) @ssbarnea
- Modify package version info in meta-data (#530) @priyamsahoo
- Fix intermittent EE test failures (#533) @ganeshrn
- Fix github issue links in docs (#573) @antdking
- Fix ansible lint config parsing (#577) @priyamsahoo
- Add env variable to remove color from command result stdout (#579) @priyamsahoo
@ansibot ansibot mentioned this pull request Jun 22, 2023
priyamsahoo pushed a commit that referenced this pull request Jun 22, 2023
## v1.1.0

### Minor Changes

- Update yaml to 2.x (#566) @priyamsahoo
- Add variable auto-completion feature when cursor inside jinja inline brackets (#552) @priyamsahoo

### Bugfixes

- Get module route for FQCN with more than 3 elements (#538) @fredericgiquel
- Replace sphinx with mkdocs (#544) @ssbarnea
- Modify package version info in meta-data (#530) @priyamsahoo
- Fix intermittent EE test failures (#533) @ganeshrn
- Fix github issue links in docs (#573) @antdking
- Fix ansible lint config parsing (#577) @priyamsahoo
- Add env variable to remove color from command result stdout (#579) @priyamsahoo

Co-authored-by: Ansible DevTools <ansible-devtools@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants