This repository has been archived by the owner on Mar 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 90
Get module route for FQCN with more than 3 elements #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyamsahoo
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay!
Looks good to me.
github-actions bot
pushed a commit
that referenced
this pull request
May 10, 2023
## v1.1.0 - Bump json5 from 2.2.1 to 2.2.3 (#539) ### Minor Changes - Add variable auto-completion feature when cursor inside jinja inline brackets (#552) @priyamsahoo ### Bugfixes - Get module route for FQCN with more than 3 elements (#538) @fredericgiquel - Replace sphinx with mkdocs (#544) @ssbarnea
Closed
github-actions bot
pushed a commit
that referenced
this pull request
Jun 5, 2023
## v1.0.5 ### Minor Changes - Add variable auto-completion feature when cursor inside jinja inline brackets (#552) @priyamsahoo ### Bugfixes - Get module route for FQCN with more than 3 elements (#538) @fredericgiquel - Replace sphinx with mkdocs (#544) @ssbarnea - Bump json5 from 2.2.1 to 2.2.3 (#539)
Closed
github-actions bot
pushed a commit
that referenced
this pull request
Jun 22, 2023
## v1.1.0 ### Minor Changes - Update yaml to 2.x (#566) @priyamsahoo - Add variable auto-completion feature when cursor inside jinja inline brackets (#552) @priyamsahoo ### Bugfixes - Get module route for FQCN with more than 3 elements (#538) @fredericgiquel - Replace sphinx with mkdocs (#544) @ssbarnea - Modify package version info in meta-data (#530) @priyamsahoo - Fix intermittent EE test failures (#533) @ganeshrn - Fix github issue links in docs (#573) @antdking - Fix ansible lint config parsing (#577) @priyamsahoo - Add env variable to remove color from command result stdout (#579) @priyamsahoo
Merged
priyamsahoo
pushed a commit
that referenced
this pull request
Jun 22, 2023
## v1.1.0 ### Minor Changes - Update yaml to 2.x (#566) @priyamsahoo - Add variable auto-completion feature when cursor inside jinja inline brackets (#552) @priyamsahoo ### Bugfixes - Get module route for FQCN with more than 3 elements (#538) @fredericgiquel - Replace sphinx with mkdocs (#544) @ssbarnea - Modify package version info in meta-data (#530) @priyamsahoo - Fix intermittent EE test failures (#533) @ganeshrn - Fix github issue links in docs (#573) @antdking - Fix ansible lint config parsing (#577) @priyamsahoo - Add env variable to remove color from command result stdout (#579) @priyamsahoo Co-authored-by: Ansible DevTools <ansible-devtools@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the previous one (#449).
Last version of community.general use redirected module with more than 3 elements. This case is not handled properly. The redirected modules are seen in completion but without documentation and using the wrong category/kind. The problem can be seen in the following screenshot.
This PR fixes the problem and adds tests to detect it.
The result can be seen in the following screenshot.