Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

Check file for playbook before running syntax-check #89

Merged
merged 3 commits into from Oct 22, 2021

Conversation

priyamsahoo
Copy link
Contributor

@priyamsahoo priyamsahoo commented Oct 22, 2021

The PR has the code to check a file for playbook before running --syntax-check during validation. This is to avoid errors generated by --syntax-check on non-playbook files (i.e., task files, var files, galaxy.yml files, etc.).
The content of the PR:

Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Determining if a file is a playbook or another file type is far more complex than this and we should make the determined file type visible in the ui in the future. Still this change looks as good improvement of current behavior.

@ssbarnea ssbarnea merged commit 8e3e975 into ansible:main Oct 22, 2021
@priyamsahoo priyamsahoo deleted the syntax-check-task-files branch September 13, 2022 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The service ansible-playbook --syntax-check does not check file before execution
3 participants