Add has_jinja and has_glob to text module (#2794)

This should make it easier to reuse these utility functions.

Related: #2749

.github/workflows/tox.yml

@@ -83,7 +83,7 @@ jobs:
       WSLENV: FORCE_COLOR:PYTEST_REQPASS:TOXENV:GITHUB_STEP_SUMMARY
       # Number of expected test passes, safety measure for accidental skip of
       # tests. Update value if you add/remove tests.
-      PYTEST_REQPASS: 728
+      PYTEST_REQPASS: 741
 
     steps:
       - name: Activate WSL1

.pre-commit-config.yaml

@@ -178,6 +178,8 @@ repos:
     rev: v2.15.8
     hooks:
       - id: pylint
+        args:
+          - --output-format=colorized
         additional_dependencies:
           - ansible-compat>=2.2.6
           - ansible-core>=2.14.0

src/ansiblelint/rules/deprecated_bare_vars.py

@@ -23,10 +23,10 @@
 from __future__ import annotations
 
 import os
-import re
 from typing import TYPE_CHECKING, Any
 
 from ansiblelint.rules import AnsibleLintRule
+from ansiblelint.text import has_glob, has_jinja
 
 if TYPE_CHECKING:
     from ansiblelint.file_utils import Lintable
@@ -45,9 +45,6 @@ class UsingBareVariablesIsDeprecatedRule(AnsibleLintRule):
     tags = ["deprecations"]
     version_added = "historic"
 
-    _jinja = re.compile(r"{[{%].*[%}]}", re.DOTALL)
-    _glob = re.compile("[][*?]")
-
     def matchtask(
         self, task: dict[str, Any], file: Lintable | None = None
     ) -> bool | str:
@@ -80,13 +77,13 @@ def matchtask(
     def _matchvar(
         self, varstring: str, task: dict[str, Any], loop_type: str
     ) -> bool | str:
-        if isinstance(varstring, str) and not self._jinja.match(varstring):
+        if isinstance(varstring, str) and not has_jinja(varstring):
             valid = loop_type == "with_fileglob" and bool(
-                self._jinja.search(varstring) or self._glob.search(varstring)
+                has_jinja(varstring) or has_glob(varstring)
             )
 
             valid |= loop_type == "with_filetree" and bool(
-                self._jinja.search(varstring) or varstring.endswith(os.sep)
+                has_jinja(varstring) or varstring.endswith(os.sep)
             )
             if not valid:
                 message = (

src/ansiblelint/text.py

@@ -2,6 +2,10 @@
 from __future__ import annotations
 
 import re
+from functools import lru_cache
+
+RE_HAS_JINJA = re.compile(r"{[{%#].*[%#}]}", re.DOTALL)
+RE_HAS_GLOB = re.compile("[][*?]")
 
 
 def strip_ansi_escape(data: str | bytes) -> str:
@@ -32,3 +36,15 @@ def removeprefix(self: str, prefix: str) -> str:
     if self.startswith(prefix):
         return self[len(prefix) :]
     return self[:]
+
+
+@lru_cache(maxsize=None)
+def has_jinja(value: str) -> bool:
+    """Return true if a string seems to contain jinja templating."""
+    return bool(isinstance(value, str) and RE_HAS_JINJA.search(value))
+
+
+@lru_cache(maxsize=None)
+def has_glob(value: str) -> bool:
+    """Return true if a string looks like having a glob pattern."""
+    return bool(isinstance(value, str) and RE_HAS_GLOB.search(value))

test/test_text.py

@@ -0,0 +1,39 @@
+"""Tests for text module."""
+from typing import Any
+
+import pytest
+
+from ansiblelint.text import has_glob, has_jinja
+
+
+@pytest.mark.parametrize(
+    ("value", "expected"),
+    (
+        pytest.param("", False, id="0"),
+        pytest.param("{{ }}", True, id="1"),
+        pytest.param("foo {# #} bar", True, id="2"),
+        pytest.param("foo \n{% %} bar", True, id="3"),
+        pytest.param(None, False, id="4"),
+        pytest.param(42, False, id="5"),
+        pytest.param(True, False, id="6"),
+    ),
+)
+def test_has_jinja(value: Any, expected: bool) -> None:
+    """Tests for has_jinja()."""
+    assert has_jinja(value) == expected
+
+
+@pytest.mark.parametrize(
+    ("value", "expected"),
+    (
+        pytest.param("", False, id="0"),
+        pytest.param("*", True, id="1"),
+        pytest.param("foo.*", True, id="2"),
+        pytest.param(None, False, id="4"),
+        pytest.param(42, False, id="5"),
+        pytest.param(True, False, id="6"),
+    ),
+)
+def test_has_glob(value: Any, expected: bool) -> None:
+    """Tests for has_jinja()."""
+    assert has_glob(value) == expected