Change meta rules to use matchyaml instead of matchplay (#2296)

examples/roles/meta_noqa/meta/main.yml

@@ -0,0 +1,7 @@
+---
+galaxy_info: # noqa meta-incorrect
+  author: your name # noqa meta-no-info
+  description: missing min_ansible_version and platforms. author default not changed
+  license: MIT
+  min_ansible_version: "2.10"
+  platforms: []

src/ansiblelint/rules/__init__.py

@@ -421,6 +421,8 @@ def run(  # noqa: max-complexity: 12
                 ]
 
         for rule in self.rules:
+            if rule.id == "syntax-check":
+                continue
             if (
                 not tags
                 or rule.has_dynamic_tags

src/ansiblelint/rules/meta_incorrect.py

@@ -32,22 +32,24 @@ class MetaChangeFromDefaultRule(AnsibleLintRule):
     tags = ["metadata"]
     version_added = "v4.0.0"
 
-    def matchplay(self, file: Lintable, data: odict[str, Any]) -> List[MatchError]:
+    def matchyaml(self, file: Lintable) -> List[MatchError]:
         if file.kind != "meta":
             return []
 
-        galaxy_info = data.get("galaxy_info", None)
+        galaxy_info = file.data.get("galaxy_info", None)
         if not galaxy_info:
             return []
 
         results = []
         for field, default in self.field_defaults:
             value = galaxy_info.get(field, None)
             if value and value == default:
+                if "meta-incorrect" in file.data.get("skipped_rules", []):
+                    continue
                 results.append(
                     self.create_matcherror(
                         filename=file,
-                        linenumber=data[LINE_NUMBER_KEY],
+                        linenumber=file.data[LINE_NUMBER_KEY],
                         message=f"Should change default metadata: {field}",
                     )
                 )

src/ansiblelint/rules/meta_no_tags.py

@@ -32,11 +32,12 @@ class MetaTagValidRule(AnsibleLintRule):
 
     TAG_REGEXP = re.compile("^[a-z0-9]+$")
 
-    def matchplay(self, file: Lintable, data: odict[str, Any]) -> List[MatchError]:
+    def matchyaml(self, file: Lintable) -> List[MatchError]:
+        """Find violations inside meta files."""
         if file.kind != "meta":
             return []
 
-        galaxy_info = data.get("galaxy_info", None)
+        galaxy_info = file.data.get("galaxy_info", None)
         if not galaxy_info:
             return []
 

src/ansiblelint/rules/meta_video_links.py

@@ -35,11 +35,11 @@ class MetaVideoLinksRule(AnsibleLintRule):
         "youtube": re.compile(r"https://youtu\.be/([0-9A-Za-z-_]+)"),
     }
 
-    def matchplay(self, file: Lintable, data: odict[str, Any]) -> List[MatchError]:
+    def matchyaml(self, file: Lintable) -> List[MatchError]:
         if file.kind != "meta":
             return []
 
-        galaxy_info = data.get("galaxy_info", None)
+        galaxy_info = file.data.get("galaxy_info", None)
         if not galaxy_info:
             return []
 

test/test_skip_inside_yaml.py

@@ -1,7 +1,7 @@
 """Tests related to use of inline noqa."""
 import pytest
 
-from ansiblelint.testing import RunFromText
+from ansiblelint.testing import RunFromText, run_ansible_lint
 
 ROLE_TASKS = """\
 ---
@@ -74,16 +74,6 @@
         - skip_ansible_lint
 """
 
-ROLE_META = """\
----
-galaxy_info:  # noqa meta-no-info
-  author: your name  # noqa meta-incorrect
-  description: missing min_ansible_version and platforms. author default not changed
-  license: MIT
-  min_ansible_version: "2.10"
-  platforms: []
-"""
-
 ROLE_TASKS_WITH_BLOCK_BECOME = """\
 ---
 - hosts: localhost
@@ -129,7 +119,10 @@ def test_playbook(
     assert len(results) == results_num
 
 
-def test_role_meta(default_text_runner: RunFromText) -> None:
-    """Check that role meta can contain skips."""
-    results = default_text_runner.run_role_meta_main(ROLE_META)
-    assert len(results) == 0
+def test_role_meta() -> None:
+    """Test running from inside meta folder."""
+    role_path = "examples/roles/meta_noqa"
+
+    result = run_ansible_lint("-v", role_path)
+    assert len(result.stdout) == 0
+    assert result.returncode == 0