--fix will now default to all (#3777)

ansible · Sep 28, 2023 · 59f4141 · 59f4141
1 parent 53421b2
commit 59f4141
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/ansiblelint/cli.py b/src/ansiblelint/cli.py
@@ -223,7 +223,10 @@ def merge_fix_list_config(
 
         When from_cli is not an empty list, we ignore the from_file value.
         """
-        arguments = from_file if from_cli == [cls._default] else from_cli
+        if not from_file:
+            arguments = ["all"] if from_cli == [cls._default] else from_cli
+        else:
+            arguments = from_file
         for magic_value in ("none", "all"):
             if magic_value in arguments and len(arguments) > 1:
                 msg = f"When passing '{magic_value}' to '--fix', you cannot pass other values."

diff --git a/test/test_cli.py b/test/test_cli.py
@@ -72,7 +72,7 @@ def test_ensure_config_are_equal(
             True,
             ["--fix"],
             "test/fixtures/config-with-write-all.yml",
-            [],
+            ["all"],
             id="1",
         ),
         pytest.param(
@@ -128,14 +128,14 @@ def test_ensure_config_are_equal(
             False,
             ["--fix", "examples/playbooks/example.yml"],
             "test/fixtures/config-with-write-all.yml",
-            [],
+            ["all"],
             id="9",
         ),
         pytest.param(
             False,
             ["--fix", "examples/playbooks/example.yml", "non-existent.yml"],
             "test/fixtures/config-with-write-all.yml",
-            [],
+            ["all"],
             id="10",
         ),
     ),