Refactor meta-incorrect tests (#3266)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ajinkya Udgirkar <ajinkyaudgirkar@gmail.com>

.github/workflows/tox.yml

@@ -59,7 +59,7 @@ jobs:
       WSLENV: FORCE_COLOR:PYTEST_REQPASS:TOXENV:GITHUB_STEP_SUMMARY
       # Number of expected test passes, safety measure for accidental skip of
       # tests. Update value if you add/remove tests.
-      PYTEST_REQPASS: 798
+      PYTEST_REQPASS: 797
     steps:
       - name: Activate WSL1
         if: "contains(matrix.shell, 'wsl')"

examples/roles/meta_incorrect_fail/meta/main.yml

@@ -0,0 +1,12 @@
+# Fixture for meta-incorrect
+---
+galaxy_info: # <-- 4x meta-incorrect
+  author: your name
+  description: your description
+  company: your company (optional)
+  license: license (GPLv2, CC-BY, etc)
+  min_ansible_version: "2.12"
+  platforms:
+    - name: EL
+      versions:
+        - "7"

src/ansiblelint/rules/meta_incorrect.py

@@ -2,6 +2,7 @@
 # Copyright (c) 2018, Ansible Project
 from __future__ import annotations
 
+import sys
 from typing import TYPE_CHECKING
 
 from ansiblelint.constants import LINE_NUMBER_KEY
@@ -54,3 +55,24 @@ def matchyaml(self, file: Lintable) -> list[MatchError]:
                 )
 
         return results
+
+
+if "pytest" in sys.modules:
+    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
+    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+
+    def test_default_galaxy_info(
+        default_rules_collection: RulesCollection,
+    ) -> None:
+        """Test for meta-incorrect."""
+        results = Runner(
+            "examples/roles/meta_incorrect_fail", rules=default_rules_collection
+        ).run()
+        for result in results:
+            assert result.rule.id == "meta-incorrect"
+        assert len(results) == 4
+
+        assert "Should change default metadata: author" in str(results)
+        assert "Should change default metadata: description" in str(results)
+        assert "Should change default metadata: company" in str(results)
+        assert "Should change default metadata: license" in str(results)

src/ansiblelint/rules/meta_video_links.py

@@ -85,12 +85,6 @@ def matchyaml(self, file: Lintable) -> list[MatchError]:
 if "pytest" in sys.modules:
     import pytest
 
-    META_NO_GALAXY_INFO = """
-    galaxy_information:
-    video_links:
-    - url: https://www.youtube.com/watch?v=aWmRepTSFKs&feature=youtu.be
-    """
-
     from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
     from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports