schema: detect invalid space in meta runtime (#2873)

Co-authored-by: Ajinkya Udgirkar <ajinkyaudgirkar@gmail.com>
ansible · Jan 10, 2023 · d3b2bae · d3b2bae
1 parent fb6a3eb
commit d3b2bae
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 2 deletions.
diff --git a/examples/playbooks/collections/requirements.yml b/examples/playbooks/collections/requirements.yml
@@ -3,5 +3,5 @@ collections:
   version: 0.1.0
 - name: ansible-posix-1.4.0.tar.gz
   version: 1.4.0
-- name: community-general-6.1.0.tar.gz
-  version: 6.1.0
+- name: community-general-6.2.0.tar.gz
+  version: 6.2.0
diff --git a/src/ansiblelint/schemas/meta-runtime.json b/src/ansiblelint/schemas/meta-runtime.json
@@ -72,6 +72,7 @@
     },
     "requires_ansible": {
       "examples": [">=2.10,<2.11"],
+      "pattern": "^[^\\s]*$",
       "title": "The version of Ansible Core (ansible-core) required to use the collection. Multiple versions can be separated with a comma.",
       "type": "string"
     }

diff --git a/test/schemas/negative_test/meta/runtime.yml b/test/schemas/negative_test/meta/runtime.yml
@@ -0,0 +1 @@
+requires_ansible: ">= 2.12" # invalid as space is not allowed!
diff --git a/test/schemas/negative_test/meta/runtime.yml.md b/test/schemas/negative_test/meta/runtime.yml.md
@@ -0,0 +1,34 @@
+# ajv errors
+
+```json
+[
+  {
+    "instancePath": "/requires_ansible",
+    "keyword": "pattern",
+    "message": "must match pattern \"^[^\\s]*$\"",
+    "params": {
+      "pattern": "^[^\\s]*$"
+    },
+    "schemaPath": "#/properties/requires_ansible/pattern"
+  }
+]
+```
+
+# check-jsonschema
+
+stdout:
+
+```json
+{
+  "status": "fail",
+  "errors": [
+    {
+      "filename": "negative_test/meta/runtime.yml",
+      "path": "$.requires_ansible",
+      "message": "'>= 2.12' does not match '^[^\\\\s]*$'",
+      "has_sub_errors": false
+    }
+  ],
+  "parse_errors": []
+}
+```