Ensure that rule import failures are not ignored

ansible · Feb 5, 2023 · e80786e · e80786e
1 parent 69bed5c
commit e80786e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/ansiblelint/rules/__init__.py b/src/ansiblelint/rules/__init__.py
@@ -337,11 +337,7 @@ def all_subclasses(cls: type) -> set[type]:
         # load all modules in the directory
         for f in Path(directory).glob("*.py"):
             if "__" not in f.stem and f.stem not in "conftest":
-                try:
-                    import_module(f"{f.stem}")
-
-                except ImportError as exc:
-                    _logger.warning("Ignore loading rule from %s due to %s", f, exc)
+                import_module(f"{f.stem}")
     # restore sys.path
     sys.path = orig_sys_path
 

diff --git a/src/ansiblelint/rules/galaxy.py b/src/ansiblelint/rules/galaxy.py
@@ -6,8 +6,6 @@
 from functools import total_ordering
 from typing import TYPE_CHECKING, Any
 
-import pytest
-
 from ansiblelint.constants import LINE_NUMBER_KEY
 from ansiblelint.errors import MatchError
 from ansiblelint.rules import AnsibleLintRule
@@ -123,6 +121,9 @@ def _coerce(other: object) -> Version:
 
 if "pytest" in sys.modules:  # noqa: C901
 
+    import pytest
+
+    # pylint: disable=ungrouped-imports
     from ansiblelint.rules import RulesCollection
     from ansiblelint.runner import Runner