Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a packaging extra for pulling ansible-core #1717

Closed
webknjaz opened this issue Sep 6, 2021 · 1 comment · Fixed by #1720
Closed

Add a packaging extra for pulling ansible-core #1717

webknjaz opened this issue Sep 6, 2021 · 1 comment · Fixed by #1720
Assignees
@ssbarnea
Labels
bug feedback-needed Divergent oppinions, additional feedback is desired in order to unblock it. help wanted proposal

Comments

@webknjaz
Copy link
Member

webknjaz commented Sep 6, 2021

Issue Type

  • Feature request

Desired Behaviour

There's extras in setup.cfg that depend on ansible and ansible-base. We need a similar one for ansible-core.
@webknjaz webknjaz added help wanted new Triage required proposal feature enhancement feedback-needed Divergent oppinions, additional feedback is desired in order to unblock it. labels Sep 6, 2021
@ssbarnea
Copy link
Member

ssbarnea commented Sep 7, 2021

I think that is a bugfix and we should just fix it at https://github.com/ansible-community/ansible-lint/blob/main/setup.cfg#L97-L98

Basically we will not have an extra for 2.10, but if someone needs 2.10 in particular they can install it without an extra.

Just replace ansible-base with ansible-core and we can call this fixed.

@ssbarnea ssbarnea added bug and removed new Triage required feature enhancement labels Sep 7, 2021
ssbarnea added a commit that referenced this issue Sep 7, 2021
@ssbarnea
Make core extra use ansible-core
7604a60 
Fixes: #1717
@ssbarnea ssbarnea mentioned this issue Sep 7, 2021
Merged
@ssbarnea ssbarnea changed the title [TODO] Add a packaging extra for pulling ansible-core Add a packaging extra for pulling ansible-core Sep 7, 2021
@ssbarnea ssbarnea self-assigned this Sep 7, 2021
ssbarnea added a commit that referenced this issue Sep 7, 2021
@ssbarnea
Make core extra use ansible-core
8e37f88 
Fixes: #1717
ssbarnea added a commit that referenced this issue Sep 7, 2021
@ssbarnea
Make core extra use ansible-core
a2e3657 
Fixes: #1717
ssbarnea added a commit that referenced this issue Sep 16, 2021
@ssbarnea
Make core extra use ansible-core
c6552ce 
Fixes: #1717
ssbarnea added a commit that referenced this issue Sep 16, 2021
@ssbarnea
Make core extra use ansible-core
0d8e86d 
Fixes: #1717
ssbarnea added a commit that referenced this issue Sep 27, 2021
@ssbarnea
Make core extra use ansible-core (#1720)
d524cac 
Fixes: #1717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssbarnea ssbarnea

Labels
bug feedback-needed Divergent oppinions, additional feedback is desired in order to unblock it. help wanted proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make core extra use ansible-core ansible/ansible-lint
2 participants
@ssbarnea @webknjaz