Add support for py310 #1734
Merged
Add support for py310 #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
fix/py310
branch
2 times, most recently
from
8a62a75
to
13b79ad
Compare
ssbarnea
force-pushed
the
fix/py310
branch
2 times, most recently
from
d1aa308
to
6a9aeb2
Compare
webknjaz
suggested changes
Oct 6, 2021
tadeboro
suggested changes
Oct 6, 2021
Related: ansible/ansible#74658 Related: ansible/ansible#74660 Related: ansible/team-devtools#6
tadeboro
approved these changes
Oct 6, 2021
webknjaz
reviewed
Oct 6, 2021
| @@ -194,6 +199,7 @@ jobs: | |||
| env: | |||
| TOXENV: ${{ matrix.tox_env }}-core | |||
| - name: "Test with tox: ${{ matrix.tox_env }}-ansible29" | |||
| if: ${{ !matrix.skip_ansible29 }} | |||
There was a problem hiding this comment.
Nit, it would probably be more robust this way:
Suggested change
| if: ${{ !matrix.skip_ansible29 }} | |
| if: >- | |
| !toJSON(matrix.skip_ansible29) |
(but it shouldn't be mandatory at this point)
There was a problem hiding this comment.
I did not see this in GHA examples. Seems like overkill but I am curious to learn about the subject as I did find conditionals with GHA as having some unexpected behaviors at times.
webknjaz
approved these changes
Oct 6, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: ansible/team-devtools#6