Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for py310 #1734

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Add support for py310 #1734

merged 1 commit into from
Oct 6, 2021

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Oct 5, 2021

@ssbarnea ssbarnea added the bug label Oct 5, 2021
@ssbarnea ssbarnea force-pushed the fix/py310 branch 2 times, most recently from 8a62a75 to 13b79ad Compare October 5, 2021 17:26
@ssbarnea ssbarnea changed the title Add support for py3.10 Add support for py310 Oct 5, 2021
@ssbarnea ssbarnea force-pushed the fix/py310 branch 2 times, most recently from d1aa308 to 6a9aeb2 Compare October 6, 2021 07:42
@ssbarnea ssbarnea marked this pull request as ready for review October 6, 2021 08:30
@ssbarnea ssbarnea requested a review from a team as a code owner October 6, 2021 08:30
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed a lot of unrelated formatting changes. Drop them.

.github/workflows/tox.yml Outdated Show resolved Hide resolved
.github/workflows/tox.yml Outdated Show resolved Hide resolved
@@ -194,6 +199,7 @@ jobs:
env:
TOXENV: ${{ matrix.tox_env }}-core
- name: "Test with tox: ${{ matrix.tox_env }}-ansible29"
if: ${{ !matrix.skip_ansible29 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, it would probably be more robust this way:

Suggested change
if: ${{ !matrix.skip_ansible29 }}
if: >-
!toJSON(matrix.skip_ansible29)

(but it shouldn't be mandatory at this point)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see this in GHA examples. Seems like overkill but I am curious to learn about the subject as I did find conditionals with GHA as having some unexpected behaviors at times.

@ssbarnea ssbarnea merged commit 3065731 into ansible:main Oct 6, 2021
@ssbarnea ssbarnea deleted the fix/py310 branch October 6, 2021 11:09
@ssbarnea ssbarnea mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants