-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for py310 #1734
Add support for py310 #1734
Conversation
8a62a75
to
13b79ad
Compare
d1aa308
to
6a9aeb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed a lot of unrelated formatting changes. Drop them.
Related: ansible/ansible#74658 Related: ansible/ansible#74660 Related: ansible/team-devtools#6
@@ -194,6 +199,7 @@ jobs: | |||
env: | |||
TOXENV: ${{ matrix.tox_env }}-core | |||
- name: "Test with tox: ${{ matrix.tox_env }}-ansible29" | |||
if: ${{ !matrix.skip_ansible29 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, it would probably be more robust this way:
if: ${{ !matrix.skip_ansible29 }} | |
if: >- | |
!toJSON(matrix.skip_ansible29) |
(but it shouldn't be mandatory at this point)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not see this in GHA examples. Seems like overkill but I am curious to learn about the subject as I did find conditionals with GHA as having some unexpected behaviors at times.
Related: ansible/team-devtools#6