Made fqcn-builtins rule implicit #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ssbarnea
commented
Feb 16, 2022
•
ssbarnea
commented
- Made fqcn-builtins rule implicit
ssbarnea
added
AAP
ssbarnea
added a commit
to ssbarnea/ansible-lint
that referenced
this pull request
Feb 17, 2022
ssbarnea
added a commit
that referenced
this pull request
Feb 17, 2022
ssbarnea
force-pushed
the
v6/fqcn-builtins
branch
from
dc3c704
to
b3b5f25
Compare
ssbarnea
added a commit
to ssbarnea/ansible-lint
that referenced
this pull request
Feb 18, 2022
ssbarnea
added a commit
to ssbarnea/ansible-lint
that referenced
this pull request
Feb 18, 2022
ssbarnea
force-pushed
the
v6/fqcn-builtins
branch
from
b3b5f25
to
a88d9fa
Compare
|
Any timetable for this PR to be finished and merged into |
|
This PR will be merged soon but v6 will not be released very soon. Still, we need to address the explosion of errors from the eco repositories either by fixing the new rule or just by adding it to repo-exclude list. |
|
OK, I'll try to fix the issues in the DebOps repository during next week, 21-27 Feb. |
ssbarnea
added a commit
to ssbarnea/ansible-lint
that referenced
this pull request
Feb 18, 2022
Fixes exception found during testing of ansible#1908
ssbarnea
force-pushed
the
v6/fqcn-builtins
branch
from
a88d9fa
to
84c3e60
Compare
From now on, we will be requiring `fqcn-builtins` by default, matching official Ansible guidelines as documentation was already updated in that regard.
ssbarnea
force-pushed
the
v6/fqcn-builtins
branch
from
84c3e60
to
bea882f
Compare
ssbarnea
changed the title
ssbarnea
requested review from
relrod,
ganeshrn,
priyamsahoo,
cognifloyd,
a team and
cidrblock
and removed request for
a team
cidrblock
approved these changes
Feb 25, 2022
|
I've opened a follow-up issue requesting this change be reverted: #2050 |
zdtsw
added a commit
to zdtsw/infrastructure
that referenced
this pull request
Apr 6, 2022
- ansible/ansible-lint#1908 add to v6.0.0
zdtsw
added a commit
to zdtsw/infrastructure
that referenced
this pull request
Apr 6, 2022
5 tasks
Haroon-Khel
pushed a commit
to adoptium/infrastructure
that referenced
this pull request
Apr 8, 2022
* ansible: disable new fqcn ansible-lint rule - ansible/ansible-lint#1908 add to v6.0.0 * fix: ansible-lint#59 no-handler - ref: https://ansible-lint.readthedocs.io/en/latest/default_rules/#id59 * fix: lint on yaml for .ansible-lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.