--write: Do not rewrite zero 0 as octal 00 #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression tests for issue number ansible#2071. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Fixes: ansible#2071 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
cognifloyd
approved these changes
May 2, 2022
cognifloyd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
ruamel.yamlonly preserves the octal format for YAML 1.2, the effort was made to do the same for YAML 1.1 inansible-linter, asruamel.yamlconverts the octal to an int. While the code was partially copied fromruamel.yaml, the check for an actual zero got lost, resulting in the behaviour seen in #2071.Fixes: #2071